GitHub
Moderator
[SoftCSA] Remove redundant setSourcePVR call
The decode demux source is already set to PVR by
eDVBResourceManager::allocateDemux (lib/dvb/dvb.cpp), so calling
setSourcePVR(demux_id) again from the SoftDecoder is a no-op on
platforms with fixed demuxN<->dvrN routing.
On et9x00 the proprietary driver returns
ENOSYS for the second open/ioctl(DMX_SET_SOURCE)/close cycle on
the same demux fd and corrupts the default routing, so demux6
no longer reads from dvr6 and the TV decoder gets no data
(picture missing, while stream output still works).
PVR-Playback, Timeshift and Live-TV all set up the decode
demux without this extra call and work on every supported
box - it follows that the call is unnecessary on any platform,
not just et9x00.
(cherry picked from commit 8a4c9b750f23370a88a883e0df50ac7212e2cbc3)
Continue reading...
The decode demux source is already set to PVR by
eDVBResourceManager::allocateDemux (lib/dvb/dvb.cpp), so calling
setSourcePVR(demux_id) again from the SoftDecoder is a no-op on
platforms with fixed demuxN<->dvrN routing.
On et9x00 the proprietary driver returns
ENOSYS for the second open/ioctl(DMX_SET_SOURCE)/close cycle on
the same demux fd and corrupts the default routing, so demux6
no longer reads from dvr6 and the TV decoder gets no data
(picture missing, while stream output still works).
PVR-Playback, Timeshift and Live-TV all set up the decode
demux without this extra call and work on every supported
box - it follows that the call is unnecessary on any platform,
not just et9x00.
(cherry picked from commit 8a4c9b750f23370a88a883e0df50ac7212e2cbc3)
Continue reading...